cadCAD-org / cadCAD

Design, simulate, validate, and operate within complex systems
https://cadcad.org
MIT License
555 stars 271 forks source link

Debug M dictionairy unpacking in utils. #343

Closed LinuxIsCool closed 8 months ago

LinuxIsCool commented 10 months ago
  1. Add support for the case where all system params have same length that is not 1. For example:
    params = {
        'c':[1, 2],
        'd':[1, 2],
    }
  1. Add test for easy_run
danlessa commented 10 months ago

@LinuxIsCool would you mind adding a new test that reproduces the bug that this PR intends to fix?

Eg. test_sweep_params_equal_length

It would be even cooler if the count of parameters / length of the param list is parametrized

LinuxIsCool commented 10 months ago

@danlessa It's here: https://github.com/longtailfinancial/cadCAD/blob/16703b306f04f0c54f7ae72d6ff0754b2053ba3f/testing/tools/test_tools.py#L32

danlessa commented 8 months ago

LGTM