search

cadCAD-org / cadCAD

Design, simulate, validate, and operate within complex systems
https://cadcad.org
MIT License
541 stars 270 forks source link

Bug: sweep_cartesian_product does not play nice with config_sim #354

Closed LinuxIsCool closed 5 months ago

LinuxIsCool commented 6 months ago

This line casts parameter sets to tuples: https://github.com/cadCAD-org/cadCAD/blob/9047c1329c8b0259df7de4e8dfe4f65053f89fdb/cadCAD/tools/preparation.py#L29

But this line expects specifically lists, otherwise giving an error: https://github.com/cadCAD-org/cadCAD/blob/9047c1329c8b0259df7de4e8dfe4f65053f89fdb/cadCAD/configuration/utils/__init__.py#L180

Thus using sweep_cartesian_product and then easy_run is throwing an error.

I'll submit a PR to resolve this in a moment.

linear[bot] commented 6 months ago

CORE-108 Bug: sweep_cartesian_product does not play nice with config_sim