cadCAD-org / cadcad-ri

The Reference Implementation
https://cadcad.org
BSD 2-Clause "Simplified" License
19 stars 10 forks source link

Implement Dimension #4

Closed emanuellima1 closed 2 years ago

emanuellima1 commented 2 years ago

Question:

I still have to write more tests, but will open the discussion now.

tylerdmace commented 2 years ago

I don't see any reason why it would need to be a union. Type should suffice. Also, are the params ordered when declared as a @dataclass? If, so, I'd like to see dtype first followed by name and description.

tylerdmace commented 2 years ago

One last change that I see which is that I believe we want __eq__ to also check description. @mzargham Is this take correct?

emanuellima1 commented 2 years ago

It is checking, on line 93.