Closed emanuellima1 closed 2 years ago
I don't see any reason why it would need to be a union. Type should suffice. Also, are the params ordered when declared as a @dataclass? If, so, I'd like to see dtype first followed by name and description.
One last change that I see which is that I believe we want __eq__
to also check description
. @mzargham Is this take correct?
It is checking, on line 93.
Question:
dtype
is just atype
? I think it should be a union, or else it will cause problems.I still have to write more tests, but will open the discussion now.