cadadr / elisp

Göktuğ's Emacs Lisp programs
79 stars 21 forks source link

Incorrect upcoming week info #18

Closed kaushalmodi closed 7 years ago

kaushalmodi commented 7 years ago

The upcoming week information graph created by forecast.el is very incorrect.

Here is what the package shows:

image

And here is what's actual (I know that the upcoming weekend is frigid!), and also shown by darksky.net:

image

I see no correlation between the days or the temperature numbers between forecast.el and darksky.net.

kaushalmodi commented 7 years ago

Ah! The bug is that the upcoming graph is printed in mirror fashion but the Day names printed (Fri Sat Sun ..) are correct. Other data like Precipitation, Wind speed, etc is in the right order though.

So the high/low temps shown above in the top image for Wed is actually for Sun, the one shown for Tue is actually for Mon, etc.

cadadr commented 7 years ago

Hi, thanks a lot for all your patches, I've merged all of them just now. I've made a silly error with the hourly graph and carried it over here too... I fixed the hourly a couple days ago. Sorry for the inconvenience, and thanks again for the fixes.

kaushalmodi commented 7 years ago

You are welcome. Thanks for accepting the patches. This is a very cool package.

cadadr commented 7 years ago

You're very welcome, thanks for your kind words :smile: .