cadadr / elisp

Göktuğ's Emacs Lisp programs
79 stars 21 forks source link

Support recursive directories in bibliothek.el #29

Closed terlar closed 6 years ago

terlar commented 6 years ago

I don't know if you intended to support this behaviour or if I need to add every sub-directory to the bibliothek-path. I think it would be a nice addition to support non-flat directories as well. Only thing I am uncertain about here is the sorting.

cadadr commented 6 years ago

Hi, thanks a lot for your interest!

I'd certainly want to support this behaviour, but I think it would be better to have an option to enable it (like with a boolean defcustom ‘bibliothek-recursive’), rather than it be the default behaviour. Would you mind doing that, and porting the patch to the current master version of the file, as I've just pushed some changes to address some issues pointed out in the Melpa issue tracker that interferes with your patch

terlar commented 6 years ago

Sure, I understand and agree, having it configurable would be best, I can do it later today.

Thanks for the package, I think it will come in handy.

terlar commented 6 years ago

@cadadr I have updated it now with a customizable bool variable, and then it will choose either of those two methods. I default to nil which mimics the previous default behaviour.

cadadr commented 6 years ago

I've merged this, thanks a lot! I'm confused with what to do with copyright lines when accepting patches, but if you think it's necessary (or if you'd like) you can send a patch my way to add a copyright line for yourself.

terlar commented 6 years ago

No need in this case, thanks for asking.