cadamsdev / vscode-jetbrains-icon-theme

Icon theme for Visual Studio Code using official JetBrains product icons
Other
40 stars 27 forks source link

Add icons for specific folders #37

Closed cadamsdev closed 1 year ago

cadamsdev commented 2 years ago

e.g for folders named "resources"

We could use icon resourcesRoot

This feature should be toggleable.

reekystive commented 1 year ago

Personally I don't like assigning icons for specific folders (e.g. types, resources, images, assets) because they can be inaccurate, appear in all types of projects, and will be annoying. Sometimes my resources folder is just resource-related code, not resource files. Also types folder is only valid for some specific projects (e.g. TypeScript).

For reference, JetBrains IDEs never simply assign icons by folder names. I think this is something that needs serious consideration. :D

reekystive commented 1 year ago

Also, unlike file extensions, .ts must (probably) be a TypeScript file, and .png must be an image file, but there's nothing that says that files in the resources folder must be resource files.

So I think what a folder is used for depends on the user's own intent, so it requires the user to specify a folder to be used for a specific purpose themselves, rather than simply assigning icons based on the filename. Like "Mark Directory As" in JetBrains' IDE:

Screenshot 2023-09-01 at 14 18 33
LucausMartin commented 1 year ago

Maybe two solutions can be made, one is to not distinguish folders with special meanings, and the other is to distinguish. Because different people have different understandings of special folders

cadamsdev commented 1 year ago

Closing this issue for now to keep the icon set simple. Definitely open to suggestions though.