search

cadars / john-doe

A simple way to make HTML websites
https://john-doe.neocities.org
The Unlicense
469 stars 123 forks source link

Remove positioning absolute from sections #9

Open JvanderCeelen opened 3 years ago

JvanderCeelen commented 3 years ago

Hi,

I love the webpage you built. So simple and elegant. You could, if you want, remove the positioning absolute from the sections and hide the default section if another section is targeted. It might improve SEO, but more importantly, it actually shows in the DOM what is visible on screen and what is not. This helps screen readers for instance.

I've made a PR for the changes. It somehow shows up a lot more changes than I've made, but that might have something to do with line endings? I'm not sure. Let me know if I can do anything about that.

Thanks for the nice work, very inspiring!

Jonathan

cadars commented 3 years ago

Looking good! It would partially fix #5 , but not entirely: as you can read over there, I'm also concerned about having the #home section coming last in the markup, but I don't see how to make it happen…

JvanderCeelen commented 3 years ago

Yeah I totally agree with that concern about the home section being last. It is not ideal. I don't know if it has any real disadvantages, but it's just not the right order :D. As far as I know there's no way to target a previous sibling with just css. If I think of something I will let you know.

cadars commented 3 years ago

You're right, I might just do it this way… it's actually what I've done for another project where I duplicated the first section. (it's less of a problem because it is just a table of contents, which is fine to have both at the beginning and at the end of a document)

JvanderCeelen commented 3 years ago

Love it. Very fun way of showing the different sections of the website and very nice use of the grid system in the book itself and automatically letting it overflow in multiple columns. Very creative stuff!