cadaverous-eris / Rustic

A medieval themed Minecraft mod based around decoration, exploration, and agriculture
68 stars 35 forks source link

Crash Bug: Pushing a Pot with a Piston #176

Closed Jamdog closed 6 years ago

Jamdog commented 6 years ago

Mod Version: 1.0.3 Server Version: Forge 1.12 ModPack: Nature's Beauty v1.1

While attempting to push a Pot under a vanilla Flowerpot (because a flowerpot cannot be placed on top of a Pot, but that's a different issue), the server instantly crashes.

Single-player Crash Log is here: https://hastebin.com/obeqogirap.sql

I tested this on a server, and in single-player - both are affected.

The crash happens the moment you try to push a pot with a piston, regardless of how the piston is powered.

ferreusveritas commented 6 years ago

That link doesn't seem to have a log in it.

If I had to guess about the problem i'd say that since a pot is an inventory and thus a tile entity then the crash is probably due to the pot block moving but the tile entity being in the original location. Chests are a good example of this and why they are not able to be pushed with a piston. So the pot needs to either be made unable to be piston shoved or something special needs to be to coded in the pot to allow it to be pushed(not sure if possible). Even shulker boxes pop to an item when pushed with a piston.

In my opinion mojang needs to allow flower pots to respect the top face shape interface of a block. I think they can only sit on a full solid surface at the moment. If done properly then it could sit on walls and pots and such. I imagine a core mod could be used to pull this off in the meantime if someone was so inclined.

Are you by chance using the Quark piston feature?