cadaverous-eris / Rustic

A medieval themed Minecraft mod based around decoration, exploration, and agriculture
68 stars 35 forks source link

Performance Issues with Alchemy Condensers that have Full Slots #243

Closed Luke616 closed 4 years ago

Luke616 commented 5 years ago

Hello,

I've been running a server for a modpack with Rustic in it and have been periodically performing CPU time profiles using the mod LagGoggles. I've noticed a performance issue which stems from Alchemy devices that have items in each slot, but are not currently brewing elixirs.

2019-02-14_12 57 37 2019-02-14_12 58 07 2019-02-14_12 58 21 2019-02-14_12 58 23

This issue occurs with both standard and advanced alchemy condensers. If all slots are full, as shown in the screenshots above, the condensers will tick rapidly and cause up to ~750 us/tick worth of lag. After testing for a bit I've found this to be consistent. If either the bottles, inputs, or fuel slots are emptied, the lag does not occur and the condensers contribute a much more manageable ~5 us/tick. If all slots are emptied, the condensers contribute nothing to the server load whatsoever.

I understand if this is difficult or impossible to fix in the short term. Let me know if you'd like any more information about the issue.

Using: Rustic 1.0.15 Forge 14.23.5.2808

Thanks much, Luke616

majijn commented 5 years ago

https://github.com/the-realest-stu/Rustic/issues/184