search

cadaverous-eris / Rustic

A medieval themed Minecraft mod based around decoration, exploration, and agriculture
68 stars 35 forks source link

Brewing barrel and TE Reservoir issue. #259

Open DennisCorp opened 5 years ago

DennisCorp commented 5 years ago

When filling a brewing barrel with liquid from a Thermal Expansion Reservoir (hardened) , the reservoir will revert back to a (Basic) level.

This has occurred while playing FTB Interactions v1.5.0,

The liquid successfully goes into the barrel, but the reservoir is dropped down to basic. The same occurs with a (resonant) level reservoir, it also reverts back to (basic)

I tested with Honey, apple juice and ironberry juice, all crushed in the crushing tub. The exact amount of fluid was in the reservoir for each attempt.

Tmtravlr commented 5 years ago

I had this happen as well. It seems to be wiping the nbt data from the item as well, since I had a quality tools quality on the reservoir which disappeared.

I took a gif to show the issue: Image from Gyazo

TherminatorX commented 4 years ago

Still an issue with version 1.1.4 in August of 2020

Prunoideae commented 4 years ago

Met this issue on my own compiled binary.

https://github.com/the-realest-stu/Rustic/blob/5dcdc2b40c20c1627458924f6b010559cd72e379/src/main/java/rustic/common/tileentity/TileEntityBrewingBarrel.java#L269

@the-realest-stu Could you please replace all the lines in this file that cast a out ItemStack by using

ItemStack out = new ItemStack(in.getItem())

to

ItemStack out = in.copy()

?

new an ItemStack from Item.getItem() only gets its "default" item representation, extra data like damage, metadata or tags will be lost, using the Item.copy() method will return a full-sized copy of the original ItemStack, and in this case the bug will be fixed.