search

cadaverous-eris / Rustic

A medieval themed Minecraft mod based around decoration, exploration, and agriculture
68 stars 35 forks source link

Crash involving Rendering #56

Open loadstarnes opened 7 years ago

loadstarnes commented 7 years ago

Heres the crash report: https://pastebin.com/SN3ku0bQ

From what I can read, it involves JustEnoughItems and Rustic.

The crash can be consistently reproduced in my game with the mods listed in the crash report by pressing R (the recipe viewer control button for JEI) on a (vanilla Minecraft) apple.

I have consistently reproduced this crash in my game with ONLY the mods RUSTIC, and JEI. The crash report for when I isolated these two mods can be found here: https://pastebin.com/30tWp5kc This, I assume, means the problem is either in JEI, Rustic, or both.

It looks like the actual thing that couldn't render was "FluidBottleModel"...

Is this a JEI problem, or a Rustic problem? Is a quick fix available?

Edit: I have been able to reproduce the crash by pressing R on Rustic's crushing bucket, as well as modded foods such as the Peach from Biomes o' Plenty - but the crash report still lists Rustic's FluidBottleModel as the thing that couldn't render, and pressing R on the Peach without Rustic installed yields no crash.

DietmarKrause commented 7 years ago

same here. Trying to fill immersive creosote oil in rustics liquid barrel leads to crash and unladeable world: https://pastebin.com/Ku8asqVk.

DietmarKrause commented 7 years ago

https://github.com/AllTheMods/ATM-3/issues/51

loadstarnes commented 7 years ago

I have just reproduced the crash by trying to fill a glass bottle with apple juice from the crushing bucket.

Edit: Disabling the ability to olive-oil foods seems to prevent the crash from occurring when pressing "R" on an apple or peach, but does not seem to prevent the error when filling a water bottle with apple juice.

Edit 2: It is interesting to note that @DietmarKrause 's Java Exception is "NullPointerException", when s/he is using 1.12 and Cresosote oil in a barrel, while my error is an "ArrayIndexOutOfBoundsException", when I am using 1.11.2 and apple juice/olive oil. Perhaps these are separate errors, or perhaps there is something wrong with fluid rendering overall.

DietmarKrause commented 7 years ago

caan be: perhaps different errors . Sorry.

loadstarnes commented 7 years ago

@DietmarKrause I'm not saying they are definitely different errors. Since they both have to do with the same mod and fluid rendering, I'd say that either it's likely they are the same error, or they are related errors! Anyway, your crash report should help @the-realest-stu or whoever can fix this/tell us what's wrong

cadaverous-eris commented 7 years ago

I'll look into this now. It's definitely two different crashes, as they're coming from two separate class files, but they might both be related to the way I access fluid textures. We'll see.

cadaverous-eris commented 7 years ago

@DietmarKrause your error is unrelated, and is actually a bug in IE, which has apparently been fixed in the latest update of IE. So just wait for ATM3 to update.

@loadstarnes I'm actually not sure when I'll fix that, since it's on 1.11.2. In the meantime, using an older version of JEI should fix the problem. I, personally use version 4.3.3.269 with no problems. Also, does looking at the item in other inventories (beside JEI) work?

loadstarnes commented 7 years ago

@the-realest-stu Were you not able to reproduce the glitch? I'm not sure what item you mean by "looking at the item", which item? An empty "fluid bottle", or a fluid bottle full of olive oil? I'm able to fill a bottle with apple juice from the crushing tub, drink it, and fill it again... But in my save I haven't collected any olives yet, so if the issue is a bottle of olive oil, then I'm not sure.

I can tell you that by using JEI's modname filter (@rustic) I can view all items added by rustic that way just fine, but it seems it crashes in any recipe-mode of JEI, which is strange.

Don't worry yourself about fixing this asap, I'll just try downgrading JEI for now. Just thought reporting the crash would be better than ignoring it...

cadaverous-eris commented 7 years ago

Yeah, I haven't had any issues checking recipes with olive oil, or other fluids. The fact that it only happens in the JEI crafting grid makes me think it's actually a problem in JEI

cgiacofei commented 6 years ago

I've noticed a similar (not sure if related issue) with rendering fluid containers involving honey. The issue only seems to occur if either Biomes 'O Plenty or Apiary and Honey are loaded.

Having fluid containers filled with Rustic honey cause a rendering error and the world becomes unloadable. Both of the above mods have their own honey fluid they add so there may be a conflict.

My temporary solution has been to set Rustic's beehive spawning to zero so I'm not tempted to try and convert combs to honey.