search

caddy-dns / cloudflare

Caddy module: dns.providers.cloudflare
Apache License 2.0
436 stars 59 forks source link

downgrade caddy #71

Closed mohammed90 closed 7 months ago

mohammed90 commented 8 months ago

This does not affect the ability to build newer caddy versions. In fact, it allows the build of newer versions. This is due to nuance in Go modules algorithm as described here: https://go.dev/ref/mod#pseudo-versions. Long story short, the tag v2.7.6 was on the 2.7 branch rather than master branch, which Go version resolver does not consider it to be a proper ancestor of HEAD.

Moving forward, I recommend the version of Caddy to not be updated here unless it's dependent on a specific feature in newer version or for protection against a particular security vuln. Here we specify the minimum accepted version, but newer versions are not prohibited. Moreover, this is a library, not the main module, so it should not dictate the version of the main module.

Follow up for #70.

dsully commented 7 months ago

Would love to see this merged.

mholt commented 7 months ago

Thanks; we'll probably revert our method of tagging on branches in the future.