search

caddy-dns / cloudflare

Caddy module: dns.providers.cloudflare
Apache License 2.0
440 stars 59 forks source link

Building with latest Caddy version fails (undefined: caddytls.DNSProviderMaker) #8

Closed eddiejibson closed 4 years ago

eddiejibson commented 4 years ago

Hi,

I attempted building Caddy 2 with xcaddy. However, it seems caddytls.DNSPRoviderMaker is no longer included (I assumed this because of this commit - which stated that you'd removed the DNSProviderMaker interface which I'm assuming this module relies on?). So I obviously was not able to build correctly.

2020/05/27 19:57:50 [INFO] Build environment ready
2020/05/27 19:57:50 [INFO] Building Caddy
2020/05/27 19:57:50 [INFO] exec (timeout=0s): /usr/bin/go build -o /home/go/bin/caddy -ldflags -w -s -trimpath 
# github.com/caddyserver/tls.dns/providers/cloudflare
/home/go/pkg/mod/github.com/caddyserver/tls.dns@v0.0.0-20200501172207-b0150d143df0/providers/cloudflare/cloudflare.go:75:7: undefined: caddytls.DNSProviderMaker
2020/05/27 19:58:02 [INFO] Cleaning up temporary folder: /tmp/buildenv_2020-05-27-1957.673318377
2020/05/27 19:58:02 [FATAL] exit status 2

Here's the command I used, by the way:

./xcaddy build --with github.com/caddyserver/caddy/v2/modules/standard --with github.com/caddyserver/tls.dns/providers/cloudflare

Not sure if I've done something wrong or this interface is simply missing.

Thanks.

eddiejibson commented 4 years ago

Nevermind, I have been very foolish. I referenced an old comment with the old module URL and assumed it was correct. I should've used github.com/caddy-dns/cloudflare instead of github.com/caddyserver/tls.dns/providers/cloudflare. Apologies.