search

caddy-dns / hetzner

Caddy module: dns.providers.hetzner
MIT License
32 stars 9 forks source link

update dependencies go and libdns #12

Closed Hobby-Student closed 2 months ago

Hobby-Student commented 2 months ago

Hi there,

this commit will update libdns (hetzner) to v0.2.2. This is required by https://github.com/opnsense/plugins/issues/3872.

I don't see any conflicts in this pull request and hope it will be accepted.

mholt commented 2 months ago

Thanks for the Pr. Is the caddy version bump required? Generally plugins should only do this if needed for compilation to succeed (like new APIs).

Hobby-Student commented 2 months ago

Thanks for the Pr. Is the caddy version bump required? Generally plugins should only do this if needed for compilation to succeed (like new APIs).

I don't think it's necessary, I thought it would be a good idea to update caddy, too. If it's a problem I can change it back to the "old" version.

mholt commented 2 months ago

That might be ideal; otherwise we've found it complicates builds with combinations of plugins. We're still learning this, but I think our new advice to plugins is to not upgrade Caddy in go.mod unless really necessary. So yeah, if we could, let's revert that change at least, but then we can probably merge it.

Hobby-Student commented 2 months ago

That might be ideal; otherwise we've found it complicates builds with combinations of plugins. We're still learning this, but I think our new advice to plugins is to not upgrade Caddy in go.mod unless really necessary. So yeah, if we could, let's revert that change at least, but then we can probably merge it.

Done. I reverted caddy to v2.3.0 and ran go mod tidy. go is v1.17 to match libdns/hetzner.