search

caddy-dns / namecheap

34 stars 4 forks source link

Fix Namecheap API access #8

Closed boatrite closed 5 months ago

boatrite commented 1 year ago

Fix Namecheap API access when using namecheap caddy dns plugin by changing parameter name from 'endpoint' to 'api_endpoint' since 'api_endpoint' is what is expected.

Also run go fmt on the file.

I have an installable branch here: https://github.com/boatrite/caddy-dns-namecheap/tree/fixed-api-installable

Use it like so:

xcaddy build --with github.com/boatrite/caddy-dns-namecheap@fixed-api-installable
boatrite commented 1 year ago

Thanks. I don't actually maintain this repo though, I'll leave that up to @nrfox to approve and merge. +1 since I don't use Namecheap...

Tysm for the extra set of eyes! Sounds good

boatrite commented 1 year ago

Cleaned up branch with a rebase

nrfox commented 5 months ago

Wow sorry for the long wait on getting this one in. Thanks for the contribution @boatrite and for the review @mholt!