search

caddy-dns / route53

Caddy module: dns.providers.route53
MIT License
38 stars 31 forks source link

[FIX] Relative/absolute record name conversions #13

Closed PhoenixPeca closed 3 years ago

PhoenixPeca commented 3 years ago

Hi @danlsgiga and @mholt , please help check my codes if I have introduced any logical errors.. I'm new to Golang.. spent my entire day working on this and to test. Feel free to edit or add recommendations.. I am aware of the incorrect module references, will have them fixed after you confirm the codes. :D

Before this PR, this DNS module does not work due to recent changes in the libdns/libdns module.. I hope this will fix that issue.

It works perfectly on my side. :D image

I have tested by building using this:

xcaddy build \
    --with github.com/caddy-dns/cloudflare \
    --with github.com/PhoenixPeca/caddy-dns-route53@v1.2.6
PhoenixPeca commented 3 years ago

sorry my bad.. please ignore this PR.. i mistakenly created a pull request to edit the module references.. I figured that only repository maintainers can handle this type of changes..

PhoenixPeca commented 3 years ago

Better take a look at this instead: https://github.com/libdns/route53/pull/5

Thank you!

Best regards, Phoenix