search

caddy-dns / route53

Caddy module: dns.providers.route53
MIT License
38 stars 31 forks source link

Provider has no field or method NewSession #21

Closed eth-limo closed 2 years ago

eth-limo commented 2 years ago

I created a fork of libdns/route53 in order to test some of the recent bug fixes (https://github.com/libdns/route53/issues/7, https://github.com/libdns/route53/pull/12) and I ran across this error:

/go/pkg/mod/github.com/eth-limo/caddy-dns-route53@v1.1.5/route53.go:35:10: p.NewSession undefined (type *Provider has no field or method NewSession)

For testing purposes I pinned libdns/route53 to v1.2.1-0.20220707195619-cc1414081972 which includes an upgrade to the AWS SDK and a few other fixes.

I'm building Caddy with the following command:

go get github.com/caddyserver/xcaddy/cmd/xcaddy && \
    xcaddy build v2.5.1 \
      --with github.com/eth-limo/caddy-dns-route53@v1.1.5

I'm assuming this will be an issue once this project upgrades libdns/route53 to v1.2.1.

Thanks!

eth-limo commented 2 years ago

@aymanbagabas I think the AWS SDKv2 refactor broke this interface.

aymanbagabas commented 2 years ago

@eth-limo checkout the upgrade branch. I'm still testing it out.

aymanbagabas commented 2 years ago

@eth-limo tested the upgrade branch and was able to generate certificates. I'll make a release and close related issues.