search

caddy-dns / route53

Caddy module: dns.providers.route53
MIT License
43 stars 32 forks source link

Added multi-profile support (fixes #4) #5

Closed PhoenixPeca closed 4 years ago

PhoenixPeca commented 4 years ago

Dear caddy team, this PR adds a new argument in the route53 module where people can specify which AWS profile they want to use per virtualhost.. If not defined, it will fall back to the default profile or the profile set in the system environment..

Example:

  tls {
      dns route53 {
        max_retries 10
        aws_profile "production-profile" # New argument for multi-profile support
      }
  }

For details please read this forum thread: https://caddy.community/t/automatic-https-for-route53-multi-profile-support/10512/8

PhoenixPeca commented 4 years ago

I am not sure how you guys handle version releases of this module but i already updated some go modules as basis.. please double check before merging.. i don't want to break other people's usage.. :D

PhoenixPeca commented 4 years ago

Hi @mholt changes have been resolved. Thank you for taking the time to check!. :D

danlsgiga commented 4 years ago

LGTM too! Thanks for this PR @PhoenixPeca!