search

caddyserver / caddy-docker

Source for the official Caddy v2 Docker Image
https://hub.docker.com/_/caddy
Apache License 2.0
423 stars 75 forks source link

update Windows Server ltsc2016 to ltsc2022 #218

Closed iamCristYe closed 2 years ago

iamCristYe commented 2 years ago

see https://github.com/docker-library/official-images/pull/11661 and https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle

hairyhenderson commented 2 years ago

Thanks @iamCristYe - I had started on this locally a few days ago, but haven't issued the PR yet because I haven't gotten around to testing the changes yet.

Have you been able to test this?

Also, you'll need to rename the ltsc2016 directories to ltsc2022, and run make to make sure everything's properly regenerated (though you'll need to remove library/caddy from the diff before committing).

iamCristYe commented 2 years ago

@hairyhenderson Well to be honest I don't get a testing env right now. It would require Windows Server OS to test right? I don't have that for now. You're right that I forgot to rename the directory, I've updated that.

hairyhenderson commented 2 years ago

We've decided not to move to ltsc2022 for Caddy 2.4, and instead only add that for Caddy 2.5 (in beta now, to be released soon). When Caddy 2.5 is released we'll no longer build 2.4 images, so the ltsc2016 tag will no longer get built.