Remove explicit VOLUME instructions

caddyserver / caddy-docker

Source for the official Caddy v2 Docker Image

https://hub.docker.com/_/caddy

Apache License 2.0

423 stars 75 forks source link

Remove explicit VOLUME instructions #220

Closed OCram85 closed 2 years ago

OCram85 commented 2 years ago

:book: Summary

Removes the controversial VOLUME instructions in the Dockerfiles.

:bookmark_tabs: Test Plan

:bulb: Select your test plan for the code changes.

[ ] Tested via Github Actions
[ ] Custom test
[ ] No test plan

Details / Justification

:books: Additional Notes

As already mentioned, there should be an additional warning message about the changes and how to deal with the dopped implicit volume definitions

📌 fixes #118

hairyhenderson commented 2 years ago

I've rebased and updated the PR to avoid modifying the 2.4 images, as I only want this change to apply from v2.5 on. Once this is updated for v2.5.0 we'll stop the 2.4 images anyway.

hairyhenderson commented 2 years ago

(the gen-dockerfiles job is failing for unrelated reasons - I'm not going to block this PR on it)