search

caddyserver / caddy-docker

Source for the official Caddy v2 Docker Image
https://hub.docker.com/_/caddy
Apache License 2.0
405 stars 74 forks source link

Tag minor version #265

Closed vincentchalamon closed 1 year ago

vincentchalamon commented 1 year ago

Hi,

Thanks for Caddy, it's an awesome project I'm working with since years and implementing it in many projects!

In API Platform as on many projects, we're using caddy:2-alpine Docker image to get the latest bugfixes on Caddy 2.*. But I couldn't find any 2.5-alpine tag on it, is there any reason to not tag a minor version but only major and bugfix versions on the Caddy official Docker image?

Recently, Caddy 2.6 has been released which changes the configuration. For instance, we were using servers.protocol.experimental_http3 which has been removed: the caddy service couldn't start anymore.

mholt commented 1 year ago

@vincentchalamon I will have to leave your question to our Docker maintainers to answer, but as for this part:

Recently, Caddy 2.6 has been released which changes the configuration. For instance, we were using servers.protocol.experimental_http3 which has been removed: the caddy service couldn't start anymore.

Experimental features are expected to change and be removed. And they're documented as such so that users don't rely on them. You'll find the release notes helpful: https://github.com/caddyserver/caddy/releases/tag/v2.6.0 -- it explains what changed. Basically, you can remove that from your config now.

vincentchalamon commented 1 year ago

Hi @hairyhenderson, I don't know if you're the right person to ask, if not, sorry for the inconvenience! Do you know any reason not tagging a minor version on the Docker image? For instance: 2.6-alpine Thanks in advance for your answer

hairyhenderson commented 1 year ago

@vincentchalamon There's no strict reason not to tag the minor.

I'll consider this! @francislavoie can you think of any reason why we shouldn't add minor tags?

francislavoie commented 1 year ago

No objections from me.

hairyhenderson commented 1 year ago

I've issued #267 to add the 2.6[-*] set of tags

hairyhenderson commented 1 year ago

The change is merged, and this'll be available in the official repo when this PR merges: https://github.com/docker-library/official-images/pull/13422

Note that this only adds a minor tag starting with 2.6 - we will not be making a 2.5 set of tags.