search

caddyserver / caddy

Fast and extensible multi-platform HTTP/1-2-3 web server with automatic HTTPS
https://caddyserver.com
Apache License 2.0
57.22k stars 4k forks source link

Cookie issues over QUIC (woocommerce) #1294

Closed meyskens closed 7 years ago

meyskens commented 7 years ago

(Are you asking for help with using Caddy? Please use our forum instead: https://forum.caddyserver.com. If you are filing a bug report, please answer the following questions. If your issue is not a bug report, you do not need to use this template. Either way, please consider donating if we've helped you. Thanks!)

1. What version of Caddy are you running (caddy -version)?

0.9.3 (armhf)

2. What are you trying to do?

Woocomerce (WordPress): adding a product to a cart, aka setting a cookie (only happens on QUIC enabled chrome)

3. What is your entire Caddyfile?

abctheater.be, www.abctheater.be {
    root /var/www/abc
     fastcgi /  /var/run/php/php7.0-fpm.sock php
    rewrite {
            to {path} {path}/ /index.php?{query}
        }

}

4. How did you run Caddy (give the full command and describe the execution environment)?

systemd, QUIC enabled

5. What did you expect to see?

It being able to set the cookie

6. What did you see instead (give full error messages and/or log)?

No cookie set

7. How can someone who is starting from scratch reproduce this behavior as minimally as possible?

Install PHP, wordpress and woocomerce default configuration add a sample product and try to order it in a QUIC enabled browser

wendigo commented 7 years ago

I think it's related to: https://github.com/lucas-clemente/quic-go/issues/338 ? Fixed in https://github.com/lucas-clemente/quic-go/commit/76cf0a2345825328442ee8f57d88d8b46e0e7a03

May require updating quic-go in Caddy

mholt commented 7 years ago

^ Probably! Nice find @wendigo. I'll do a Caddy release next week that should include that fix.

mholt commented 7 years ago

@meyskens Try it now with the latest release. Still having trouble?

meyskens commented 7 years ago

@mholt am unable to test as i have another bug that causes the site not to load. Will look if it has been reported before and if not place a new issue.

elcore commented 7 years ago

Hello @meyskens,

any updates? Does it work now (with master)?

mholt commented 7 years ago

Probably busy with the holidays. :) I'll close this for now, since I'm pretty sure it's been fixed, but if you can confirm it is still there, it might be another bug in the upstream QUIC library, try filing an issue there.