caddyserver / caddy

Fast and extensible multi-platform HTTP/1-2-3 web server with automatic HTTPS
https://caddyserver.com
Apache License 2.0
57.81k stars 4.02k forks source link

Caddy 0.10.11 builds fails with status code 500 #2040

Closed klingtnet closed 6 years ago

klingtnet commented 6 years ago

Builds for caddy 0.10.11—with many but not all plugins—fail with status code 500:

How to reproduce:

$ curl 'https://caddyserver.com/download/linux/386?plugins=http.hugo%2Chttp.upload%2Ctls.dns.cloudflare%2Chttp.awses%2Chttp.jekyll%2Chttp.mailout%2Ctls.dns.otc%2Ctls.dns.ns1%2Chttp.webdav%2Chttp.locale%2Chttp.minify%2Chttp.expires%2Ctls.dns.azure%2Ctls.dns.dnsmadeeasy%2Ctls.dns.cloudxns%2Chttp.restic%2Chttp.realip%2Cdns%2Chttp.datadog%2Ctls.dns.auroradns%2Ctls.dns.exoscale%2Ctls.dns.gandi%2Ctls.dns.googlecloud%2Ctls.dns.dnsimple%2Ctls.dns.route53%2Ctls.dns.lightsail%2Chttp.cors%2Ctls.dns.linode%2Cnet%2Ctls.dns.gandiv5%2Ctls.dns.godaddy%2Ctls.dns.namecheap%2Ctls.dns.vultr%2Chttp.nobots%2Ctls.dns.dnspod%2Chttp.awslambda%2Ctls.dns.rfc2136%2Cdyndns%2Chttp.git%2Chttp.authz%2Chttp.login%2Chttp.cgi%2Ctls.dns.digitalocean%2Chttp.gopkg%2Ctls.dns.dyn%2Ctls.dns.powerdns%2Chttp.jwt%2Chttp.filter%2Chttp.proxyprotocol%2Chttp.ratelimit%2Chttp.cache%2Chttp.prometheus%2Ctls.dns.rackspace%2Chttp.ipfilter%2Ctls.dns.ovh%2Chttp.reauth%2Chttp.filemanager%2Chttp.forwardproxy'
provisioning build environment: git fetch {github.com/caddyserver/dnsproviders/cloudxns v0.1.2 https://github.com/caddyserver/dnsproviders.git}: fork/exec /usr/bin/git: no such file or directory

It does not matter which architecture you use, i.e. amd64 and arm builds fail with them same message.

klingtnet commented 6 years ago

A link to the failed CI run where I build caddy for the AUR package caddy-full-bin.

mholt commented 6 years ago

It seems some plugins are currently incompatible with this version of Caddy; I'll reach out to the devs and see if I can get them to release an update, since I think most of them have already pushed the necessary changes. They just need to go to the site. Thanks!

klingtnet commented 6 years ago

Unfortunately, it is still broken https://circleci.com/gh/klingtnet/caddy-release-downloader/71. Do you have any idea which plugin could be the problematic one?

mholt commented 6 years ago

I would if I ssh'ed in to check the logs. However I am currently mobile with limited connectivity so I am not able to do that at the moment, sorry. I'll try to do so as soon as I'm back on my home continent!

klingtnet commented 6 years ago

Any news on this? The problem still persits.

pgaskin commented 6 years ago

It's the DNS plugins. I had the same issue.

klingtnet commented 6 years ago

@geek1011 Thank you very much, I can confirm that the dns plugin (server type) breaks the build.

pgaskin commented 6 years ago

@geek1011 No problem! It took me quite a while to test everything. Maybe if @mholt made the build server automatically test a build with each plugin and showed something saying it's broken on the download page?

klingtnet commented 6 years ago

I have to omit all plugins starting with tls.dns and the dns plugin to build caddy.

mholt commented 6 years ago

It only fails if the dns plugin is selected, as far as I can tell. @miekg just has to do a new release sometime.

miekg commented 6 years ago

[ Quoting notifications@github.com in "Re: [mholt/caddy] Caddy 0.10.11 bui..." ]

It only fails if the dns plugin is selected, as far as I can tell. @miekg just has to do a new release sometime.

I tried, it failed :-( I gave up after that.

mholt commented 6 years ago

I would love to help you fix it, rather than just leaving it broken. :)

miekg commented 6 years ago

[ Quoting notifications@github.com in "Re: [mholt/caddy] Caddy 0.10.11 bui..." ]

I would love to help you fix it, rather than just leaving it broken. :)

mostly likely 'go dep' and vendoring. Would love to fix, but can't really make/find the time to deep dive into this.

pgaskin commented 6 years ago

Hmm. I did some more testing and found something unusual: If you select tls.dns.rfc2136 along with either tls.dns.route53 or tls.dns.vultr, the build breaks. Maybe conflicting vendored dependencies?

mholt commented 6 years ago

I will look into it again by checking the logs after the Caddy release tomorrow. (Plugins can be released whenever.)