search

caddyserver / caddy

Fast and extensible multi-platform HTTP/1-2-3 web server with automatic HTTPS
https://caddyserver.com
Apache License 2.0
57.4k stars 4k forks source link

chore: retract v2.8.3 in go.mod #6365

Closed mohammed90 closed 3 months ago

mohammed90 commented 4 months ago

The tag was made in error at the wrong commit.

Go modules reference for retract: https://go.dev/ref/mod#go-mod-file-retract

Are there others to retract?

francislavoie commented 4 months ago

I'm not sure we need to care about it. We can leave it as-is. .3 is the same as .2, it's harmless.

mholt commented 3 months ago

Thanks for considering this!

I think I agree with Francis, though, the docs for retract say:

A retract directive is useful when a version was published prematurely or a severe problem was discovered after the version was published.

I don't think either really apply here. Wasn't premature (just wrong commit), and not a severe problem (just repeated a tag unnecessarily).

I think I'll close this, but we can reopen if it turns out this has material advantages :) Thanks as always, Mohammed!