caddyserver / caddy

Fast and extensible multi-platform HTTP/1-2-3 web server with automatic HTTPS
https://caddyserver.com
Apache License 2.0
55.45k stars 3.91k forks source link

logging: set file mode when the file already exist. #6391

Closed ririsoft closed 2 weeks ago

ririsoft commented 2 weeks ago

101d3e7 introduced a configuration option to set the log file mode. This option was not taken into account if the file already exists, making users having to delete their logs to have new logs created with the right mode.

This was initially spotted in the discussion for 0bc27e5. This will allow users to set the mode in CaddyFile and restart their server without the need to remove previous logs.

As suggested in the commit discussion I will open a separate PR to document that log files options require a server restart to be taken into account, when the log file destination does not change.

ririsoft commented 2 weeks ago

Documentation for the option submitted in caddyserver/website#399