search

caddyserver / caddy

Fast and extensible multi-platform HTTP/1-2-3 web server with automatic HTTPS
https://caddyserver.com
Apache License 2.0
57.82k stars 4.02k forks source link

Panic after "update quic-go to v0.48.0" commit #6643

Open mattxtaz opened 5 hours ago

mattxtaz commented 5 hours ago

Caddy regularly crashes for me after upgrading to commit a211c65, update quic-go to v0.48.0. The log shows:

panic: close of closed channel
github.com/quic-go/quic-go@v0.48.0/http3/server.go:289
github.com/quic-go/quic-go/http3.(*Server).serveListener.func1()
github.com/quic-go/quic-go@v0.48.0/http3/server.go:340 +0x128
created by github.com/quic-go/quic-go/http3.(*Server).serveListener in goroutine 115
github.com/quic-go/quic-go@v0.48.0/http3/server.go:333 +0x39

Reverting to the previous commit stops the crashes.

mholt commented 5 hours ago

@marten-seemann FYI

(Graceful shutdown is hard. I assume this is related.)

francislavoie commented 5 hours ago

@mattxtaz did you try c6f2979986d87d7236b132c687c8887c92248dd8 ? It's a followup which changes how we do graceful shutdown.

mattxtaz commented 4 hours ago

Yes. Sorry I should have mentioned that. It crashes with that one too so that wasn't a fix in this case I'm afraid.