search

caddyserver / certmagic

Automatic HTTPS for any Go program: fully-managed TLS certificate issuance and renewal
https://pkg.go.dev/github.com/caddyserver/certmagic?tab=doc
Apache License 2.0
5k stars 289 forks source link

inject http01solver #271

Closed 2456868764 closed 6 months ago

mholt commented 7 months ago

What is this for? How about a little explanation?

2456868764 commented 7 months ago

What is this for? How about a little explanation?

For example, there is a scenario where there is a certificate management service that uses the certmagic library and is deployed behind the gateway. When authenticates through http-01 solver, it not only needs to start the web service to accept the authentication request, but also needs to create an Ingress route in the gateway which forwards the authentication request to the web service, so a custom HttpSolver needs to be injected to override the default implementation.

mholt commented 7 months ago

Interesting. I think most cases like this, you have the solver sit in front of CertMagic and/or its HTTP handler. Is that something that would work for you too?

mholt commented 6 months ago

Could this be done by injecting just the HTTP handler instead of replacing the whole solver? I might be exploring this.

mholt commented 6 months ago

@2456868764 I've pushed a change here that allows you to set your own Handler in the HTTP-01 solver, which is effectively the ability to inject the solver itself:

https://github.com/caddyserver/certmagic/pull/279/files#diff-0d423173eaa496408ee9e7d82ae770feaa3b860783ca6a155f6d7551cb5d4d14R50

I will be merging that soon, superseding this, if that's alright. Let me know if that doesn't work for you though! Thanks for the submission!