search

caddyserver / certmagic

Automatic HTTPS for any Go program: fully-managed TLS certificate issuance and renewal
https://pkg.go.dev/github.com/caddyserver/certmagic?tab=doc
Apache License 2.0
4.89k stars 278 forks source link

downgrade minimum Go version #289

Closed mohammed90 closed 1 month ago

mohammed90 commented 1 month ago

This currently does not work because it requires caddyserver/zerossl#1 to be merged first. That dependency forced this module to upgrade its minimum Go version. That is not needed, and it's causing pains due to mis-synchronization with other parts of Caddy ecosystem. Once caddyserver/zerossl#1 is merged, the dependency here can be updated to use the next patch release of the zerossl package, then do go mod tidy and set this PR to be ready.

Depends on caddyserver/zerossl#1

mholt commented 1 month ago

I've pushed v0.1.3 of the zerossl package which has the lower go version in go.mod; do we need to upgrade that dep in this PR?

mohammed90 commented 1 month ago

do we need to upgrade that dep in this PR?

Yes. I'm mobile right now. If you can do it, go for it. Otherwise, it's just as upgrade of zersl then go mod tidy.

mholt commented 1 month ago

I get "permission denied" when trying to push