search

caddyserver / certmagic

Automatic HTTPS for any Go program: fully-managed TLS certificate issuance and renewal
https://pkg.go.dev/github.com/caddyserver/certmagic?tab=doc
Apache License 2.0
4.89k stars 278 forks source link

Move `looking up info for HTTP validation` to warn level #290

Closed mbardelmeijer closed 1 month ago

mbardelmeijer commented 1 month ago

This PR moves looking up info for HTTP {challenge,validation} from an error to a warning level.

The reasoning for this is as follows: we see with our certmagic deploy that the .well-known/acme-challenge/xxx paths are automatically checked by old issuers that still think they are managing the domain. These acme-challenge paths are then checked by certmagic to solve the challenge, but as it's an unknown challenge token, this fails.

It's still a relevant message to log, although not at the error level, IMHO.

Fixes https://github.com/caddyserver/certmagic/issues/268

francislavoie commented 1 month ago

Makes sense to me. I've seen these in the wild on the Caddy forums on occasion, and I agree they're not errors, they should be warnings.