caddyserver / certmagic

Automatic HTTPS for any Go program: fully-managed TLS certificate issuance and renewal
https://pkg.go.dev/github.com/caddyserver/certmagic?tab=doc
Apache License 2.0
4.89k stars 278 forks source link

Sync ACME account registration #293

Closed mholt closed 1 month ago

mholt commented 1 month ago

This implements a distributed lock around registering new ACME accounts. I am not sure why this issue hasn't really appeared before, whether a recent change exposed this bug that we've always had, or we recently introduced this bug:

https://caddy.community/t/lets-encrypt-hits-rate-limit-too-many-registrations-for-this-ip/24343

Hoping this will tame things a bit. Makes sense in my head.