The authentication parameter 'realm' is REQUIRED ([RFC7235], Section 2.2).
I can't seem to find any functional meaning behind realms in this context. Squid's default realm is "Squid proxy-caching web server", so I gave descriptive realm to Caddy as well: "Caddy Secure Web Proxy".
Proxy-Authenticate: Basic -> Proxy-Authenticate: Basic realm="Caddy Secure Web Proxy"
2. Please link to the relevant issues.
Resolves #52
3. Which documentation changes (if any) need to be made because of this PR?
None
4. Checklist
[ ] I have written tests and verified that they fail without my change
Tests currently fail in master, but seemingly for unrelated reasons. I wonder if https://github.com/mholt/caddy/pull/2339 could cause "tls: no certificates configured" when launching Caddy on localhost:1234 for testing. cc @mholt
[x] I made pull request as minimal and simple as possible. If change is not small or additional dependencies are required, I opened an issue to propose and discuss the design first
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
1. What does this change do, exactly?
Even though realm was not required in older standards, newer https://tools.ietf.org/html/rfc7617 says
I can't seem to find any functional meaning behind realms in this context. Squid's default realm is "Squid proxy-caching web server", so I gave descriptive realm to Caddy as well: "Caddy Secure Web Proxy".
Proxy-Authenticate: Basic->Proxy-Authenticate: Basic realm="Caddy Secure Web Proxy"2. Please link to the relevant issues.
Resolves #52
3. Which documentation changes (if any) need to be made because of this PR?
None
4. Checklist
localhost:1234for testing. cc @mholt