caddyserver / ingress

WIP Caddy 2 ingress controller for Kubernetes
Apache License 2.0
660 stars 70 forks source link

Deprecate disableSSLRedirect with sslRedirect #105

Open nilathedragon opened 2 years ago

nilathedragon commented 2 years ago

For issue #102

Should we log a deprecation notice if we detect ingress objects using the old annotation? Could be done easily in matcher.go if we add a zap logger to the plugin.

Embraser01 commented 2 years ago

Should we log a deprecation notice if we detect ingress objects using the old annotation? Could be done easily in matcher.go if we add a zap logger to the plugin.

Fine by me

nilathedragon commented 2 years ago

image

Hmm putting it there spams the logs quite a bit. It would certainly bring the message across 😅

Embraser01 commented 2 years ago

image

Hmm putting it there spams the logs quite a bit. It would certainly bring the message across 😅

It may be too much spam 😅, the convert function may be called many times so I think we should log this warning in another way, like only if config changed. That would mean having a list of deprecation messages to log somewhere 🤔

I'm not sure on how to do that...