caddyserver / ingress

WIP Caddy 2 ingress controller for Kubernetes
Apache License 2.0
638 stars 70 forks source link

Load Balancer Annotations & AWS NLB Additional Steps #110

Closed RickFoland closed 1 year ago

RickFoland commented 1 year ago

1) Maybe I missed this, but currently there is no way to add annotations to the load balancer template through a values file. These annotations are necessary for changing the load balancer type, attaching Elastic IPs, etc. It wasn’t a big add and I can submit a pull request with my changes if this wasn’t meant to be done elsewhere.

2) This may not be supported yet, but creating an NLB instead of a classic LB in AWS still requires a couple of manual steps.

I'm currently working on a project with this, so I can help with trying things out, testing, and submitting PRs with changes that work.

Embraser01 commented 1 year ago

Hi,

For 1), you're right, we need to add a lot more templating options to our values file (#109 is almost about the same thing). Feel free to submit a PR, I'll try to get to it asap.

For 2), I'm not sure on what we could do here, as it's mainly AWS things for any LB setup. I did succeeded at running a NLB with everything working (w/ proxy protcol, direct pod traffic, ...). I'd like to add a section in the documentation on how to setup caddy ingress controller on AWS/GCP/Azure (once we actually have a website 😓, still need to work on it)

RickFoland commented 1 year ago

2) So I have the NLB working, but needed to add a couple of manual steps. I may have just missed something in my setup that would tell AWS to create the NLB properly. Do you have a copy of the annotations you used for that NLB setup? Did you have to do anything with the AWS LoadBalancer Controller?