caddyserver / ingress

WIP Caddy 2 ingress controller for Kubernetes
Apache License 2.0
637 stars 70 forks source link

fix: remove parameter that is not supported in the chart-release action #150

Closed mavimo closed 10 months ago

mavimo commented 11 months ago

Changes

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ec19f16) 37.08% compared to head (a87eba1) 37.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #150 +/- ## ======================================= Coverage 37.08% 37.08% ======================================= Files 12 12 Lines 364 364 ======================================= Hits 135 135 Misses 228 228 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Embraser01 commented 10 months ago

Checking this, the parameter does exists but isn't released yet. Should we just wait for a new release so that the this option is used or should we remove it and readd it later? (I think latest release should always be related to the Ingress controller and not to the helm chart)

mavimo commented 10 months ago

@Embraser01 maybe we can just refer to a new version instead of @v1 here, eg @HEAD_REFS WDYT?

Embraser01 commented 10 months ago

@Embraser01 maybe we can just refer to a new version instead of @v1 here, eg @HEAD_REFS WDYT?

Good for me 👍

mavimo commented 10 months ago

@Embraser01 updated as discussed.