caddyserver / ingress

WIP Caddy 2 ingress controller for Kubernetes
Apache License 2.0
637 stars 70 forks source link

feat: exposing loadBalancer.externalTrafficPolicy value #168

Closed clems71 closed 10 months ago

clems71 commented 10 months ago

Hello Caddy team!

It is often desirable to preserve the client IP when using an ingress controller. However, to achieve this, the LoadBalancer externalTrafficPolicy need to be set to Local (see references at end of PR).

This PR proposes this: exposing the externalTrafficPolicy in the values.

References

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aaf3e54) 42.19% compared to head (5a7fe2a) 42.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #168 +/- ## ======================================= Coverage 42.19% 42.19% ======================================= Files 12 12 Lines 365 365 ======================================= Hits 154 154 Misses 210 210 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

clems71 commented 10 months ago

Hello @mavimo ! Anything else I need to do on my end on this PR?

mavimo commented 10 months ago

@clems71 no and thank you for your contribution!