codecov[bot]
commented
10 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6f6f91c) 37.08% compared to head (6bc4dd9) 42.19%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #173 +/- ## ========================================== + Coverage 37.08% 42.19% +5.10% ========================================== Files 12 12 Lines 364 365 +1 ========================================== + Hits 135 154 +19 + Misses 228 210 -18 Partials 1 1 ``` | [Files](https://app.codecov.io/gh/caddyserver/ingress/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=caddyserver) | Coverage Δ | | |---|---|---| | [internal/caddy/global/tls.go](https://app.codecov.io/gh/caddyserver/ingress/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=caddyserver#diff-aW50ZXJuYWwvY2FkZHkvZ2xvYmFsL3Rscy5nbw==) | `100.00% <100.00%> (+75.00%)` | :arrow_up: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
During the code review for the contribution #133 when added test we notice that we register the same domain multiple time, this PR add test to cover the TLS plugin and fix the underground problem.