search

caddyserver / transform-encoder

Log encoder module for custom log formats
Apache License 2.0
79 stars 17 forks source link

Added alternative value for transformer #19

Closed arabcoders closed 2 years ago

arabcoders commented 2 years ago

as we discussed in https://github.com/caddyserver/caddy/issues/4924

This pull request add support for alternative transformer variables using the following syntax {var:-alt1:-alt2:-etc}

arabcoders commented 2 years ago

@mholt If you have time, please do review the changes my golang fu is not really great, i tested live on my server and it seems to be working fine, and all tests passes.

arabcoders commented 2 years ago

Just did a quick scan, but LGTM. Will let @mohammed90 decide finally to merge it though :) Thanks!

Thanks, i have been testing it since i send the PR request, so far so good no problems detected.

arabcoders commented 2 years ago

Thank you all

@mohammed90 when can we expect it to hit the main repository,

francislavoie commented 2 years ago

By "main repository", do you mean Caddy's standard distribution? Probably never, because this is a plugin.

arabcoders commented 2 years ago

By "main repository", do you mean Caddy's standard distribution? Probably never, because this is a plugin.

Sorry i wasn't clear, i mean if i go build caddy now or do 'caddy add-package` are the changes going to take time to show up in the build or as soon as they are merged into master they are pulled.

francislavoie commented 2 years ago

It's immediate for this repo, because the repo isn't using tags for versioning.