Use client_ip instead of remote_ip in common formats?

caddyserver / transform-encoder

Log encoder module for custom log formats

Apache License 2.0

75 stars 17 forks source link

Use client_ip instead of remote_ip in common formats? #45

Open fliespl opened 3 days ago

fliespl commented 3 days ago

Is there a reason for it to be remote_ip? In loadbalancer/proxy setup it states LB ip instead of end user. Client_ip is validated by caddy - i.e. cloudflare x-connecting-ip.

mohammed90 commented 3 days ago

No reason other than it's left-over from the early days when client_ip wasn't a thing. PR is welcome if you beat us to it.

fliespl commented 3 days ago

@mohammed90 done, I wasn't sure about x-forwarded-for examples in README.md so left them intact.