search

caddyserver / xcaddy

Build Caddy with plugins
Apache License 2.0
908 stars 110 forks source link

add ".exe" when cross compiling for windows #179

Closed WeidiDeng closed 5 months ago

WeidiDeng commented 5 months ago

Previously ".exe" will be added automatically when on windows, but not when cross compiling.

francislavoie commented 5 months ago

Maybe the condition should only be the target OS? I don't think the platform we're running on matters for the extension (except for choosing the default GOOS I guess). So maybe if the env var is empty it can look at runtime?

mohammed90 commented 5 months ago

@WeidiDeng, is this ready? We need to do a hotfix release, and this is a good change.

mholt commented 5 months ago

Thank you, by the way, @WeidiDeng !