search

cadence-workflow / cadence-java-client

Java framework for Cadence Workflow Service
https://cadenceworkflow.io
Other
146 stars 110 forks source link

[BUG] ManualActivityCompletionClientImpl#fail does not set activityId which causes NPE #627

Open arabczuk-equinix opened 3 years ago

arabczuk-equinix commented 3 years ago

com.uber.cadence.internal.external.ManualActivityCompletionClientImpl#fail method does not set activityId on the instance of RespondActivityTaskFailedByIDRequest, which causes com.uber.cadence.internal.testservice.ActivityId#ActivityId(java.lang.String, com.uber.cadence.WorkflowExecution, java.lang.String) constructor to throw NullPointerException

arabczuk-equinix commented 3 years ago

any updates on the issue?

longquanzheng commented 3 years ago

I will take a look.

aauramionak commented 1 year ago

Hey, any updates on this? it just requires setting activityId in 'else' section of fail() method

  public void fail(Throwable failure) {
  ...
      if (activityId == null) {
        throw new IllegalArgumentException("Either activity id or task token are required");
      }
      request.setActivityID(activityId);
rzarzecki-equinix commented 1 year ago

It has been three months now. Any update on the issue?