cadence-workflow / cadence-java-client

Java framework for Cadence Workflow Service
https://cadenceworkflow.io
Other
146 stars 110 forks source link

Replay should also check & compare if the decision results are the same #656

Open longquanzheng opened 3 years ago

longquanzheng commented 3 years ago

https://github.com/uber/cadence-java-client/blob/dca853aaa047071caab8b16a345474aa3708d162/src/main/java/com/uber/cadence/internal/replay/ReplayDecisionTaskHandler.java#L219

https://github.com/uber/cadence-java-client/blob/dca853aaa047071caab8b16a345474aa3708d162/src/main/java/com/uber/cadence/internal/replay/ReplayDecisionTaskHandler.java#L145

longquanzheng commented 2 years ago

^ this means that changing the timer value or activity input type will not break determinism check.