search

cadenkriese / Thirst

Thirst plugin for Spigot. Adds a thirst mechanic into minecraft!
GNU General Public License v3.0
1 stars 2 forks source link

Metadatas #9

Closed The-Mr-Mango closed 7 years ago

The-Mr-Mango commented 7 years ago

Hello GamerKing,

first of all: youre a king! this plugin rocks. yet, i have some issues with the metadatas. the potion metadatas wont work (and the fact that you have to place the metadatas after the item id is a bit annoying aswell) i tried making thick potions, awkward potions and regular water bottles have a different replenish amount, but it did not work :( can you fix this, or explain to me how to fix this myself (im not sure if i am doing something wrong) and could you please think of a different way to store this info maybe by doing:

item id: metadata = replenish amount

so for example:

373:1 = 50

cadenkriese commented 7 years ago

FIX - Item metadatas not working.

cadenkriese commented 7 years ago

Hello, sorry for the inconvenience but Minecraft does not differentiate potions via item data anymore. Therefore Thirst can't tell the difference between a regular water bottle and a mundane one. I'll work on the change of format in an upcoming update but there is no reliable way for me to fix the bug, sorry.

cadenkriese commented 7 years ago

I made the formatting changes, you can download the update here. I added this to the list of known bugs found on the Spigot page. You can also wait for the auto updater to refresh and notify you it should refresh in no more than two hours.

Again, sorry for the inconvenience there's nothing I can really do.

The-Mr-Mango commented 7 years ago

http://minecraft.gamepedia.com/Data_values#Potions isnt this how it works? correct me if im wrong edit: and thank you a load for the change!

cadenkriese commented 7 years ago

Yes that is how Minecraft differentiates the potions within its own local code, however, from a plugin standpoint, those hex data values are not visible, for instance, if you try using /itemdb with Essentials on all the potions you will get the same result without any actual data values.

Edit: looking into that wiki page it does look like it's saying they're stored in the data values, however, it might be an inconsistency between Minecraft versions I currently support, and while testing with the 1.11 I found there to be no difference in data values, sorry. (If there is a version that thirst supports where potion data is stored in data values it will work with Thirst since I just directly compare the values between config and item that's being consumed.)

The-Mr-Mango commented 7 years ago

ugh how inconvenient! thanks anyways. hope this get fixed soon!!

The-Mr-Mango commented 7 years ago

Reply to edit: well it says it is an article for the latest version of MC. The values are a but cryptic, but they are there. I think they are there but if you say there is no way i believe you! Would be weird to not have any data values for different potions tho...

cadenkriese commented 7 years ago

Yeah, I'm not sure how that's working I just know that in 1.11.2 I can't detect any difference in data from the items.