German config languages throw error

caderek / gramma

command-line grammar checker

https://caderek.github.io/gramma/

ISC License

252 stars 18 forks source link

German config languages throw error #25

Closed DimasVoxel closed 3 years ago

DimasVoxel commented 3 years ago

Describe the bug Using any of the German Languages throws an error:

Details: invalid json response body at http://api.grammarbot.io/v2/check reason: Unexpected token E in JSON at position 0

To Reproduce Using any of the following languages will throw the error: de de-De de-At de-CH gramma config language de-DE

Expected behavior To not throw an error

Desktop (please complete the following information):

OS: MacOS

caderek commented 3 years ago

It looks like the default API (grammarbot.io) does not support some languages that current version of LanguageTool does. I will add a proper error handling.

As I can't do anything about their API, I will suggest you to install a local instance of the LanguageTool as described here: https://github.com/caderek/gramma#installing-local-server

I will also update the README to mark which languages are supported by grammarbot.io API.

DimasVoxel commented 3 years ago

Thank you for the swift response, setting up the local server seems effortless, so I will proceed with that. Thank you!

caderek commented 3 years ago

Error handling and documentation were improved in v1.1.0. Thank you!