caderek / gramma

command-line grammar checker
https://caderek.github.io/gramma/
ISC License
251 stars 18 forks source link

New fetch #46

Open KennethTrecy opened 1 year ago

KennethTrecy commented 1 year ago

This PR allows the package gramma to be used on environments that use Node.js platform v18. It replaces isomorphic-fetch package to node-fetch package.

In addition, I noticed that pinging the server through http://localhost:8081 fails on Node.js platform v18 and the server refuses to connect. However, if the base URL is http://0.0.0.0:8081, it is able to ping the server. In Node.js platform v16, it does not have problem on using http://localhost:8081.

In my fork, I have created workflows to check the compatibility on different versions to ensure that there are no breaking changes. Yet, those workflows are not included in this PR.

Screenshot of successful workflow in my fork image

Please let me know if there is something I could improved further. Thank you.