Open jbreue16 opened 4 months ago
Since this is implemented in the axial convection-dispersion equation, I assume you guys must already have similar test cases for WENO schemes. Do you want to use those, or the one (case 6, first order rxn system) in our part I paper. @jbreue16
We dont need to reproduce the test from the paper. I think we can test this only for the LRM, just to make sure the scheme works. In my opinion we should simply compute the LRM linear benchmark example, for which we already have the analytical solution, with all reconstruction schemes and make sure they all work for a specific tolerance. If we wanted to be even more rigorous, we could implement an EOC test for all schemes in python and add this to CADET-Reference.
We can also share the work and I can add the C++ test and you can provide the python scripts, which you probably already have and only need slight modification?
On the python side:
cadet::JsonParameterProvider createLinearBenchmark
in line 877 of the JsonTestModels.cpp
test\data\lrm-pulseBenchmark.data
On the C++ side:
PR #112 added a Koren-type reconstruction FV scheme, we need to add tests for that.