Closed ronald-jaepel closed 1 month ago
Thank you for your submission, we really appreciate it!
Like many open-source projects we ask that you sign our Contributor License Agreement before we can accept your contribution. To sign, please post two separate comments based on the following templates 👇
- [ ] The CADET maintainers know my real name.
At least one of the following two applies:
- [ ] The CADET maintainers know my current employer.
- [ ] I am *not* making this contribution on behalf of my current employer.
I have read the CLA Document and I hereby sign the CLA.
1 out of 2 committers have signed the CLA.
:white_check_mark: (ronald-jaepel)[https://github.com/ronald-jaepel]
:x: @sleweke
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.
Closing. Upon consideration I'll split this into two PRs. One for each Isotherm.
This PR continues work by @sleweke to add the multicomponent Freundlich and multicomponent Sips isotherms to CADET-Core.
I've rebased the branch onto master and added two minor changes to documentation and tests.
Status and ToDos:
Currently, the Freundlich isotherm works in all tests configurations I threw at it (both components c_p > 1, cp == 0 and cp < 0).
For the Sips isotherm, the tests fail if any cp == 0.