search

cadets-ca / ets

MIT License
5 stars 3 forks source link

Done button does not show in the Add pilot screen #67

Closed huguesfcadets closed 3 years ago

huguesfcadets commented 3 years ago

Assyst ticket 8153199.

It does not show in any iPad version with any iOS version.

It does show on iPhone in portrait. Not in landscape.

kirvanp commented 3 years ago

This sounds like the traitCollection bug. I believe that my last submission fixes it.

huguesfcadets commented 3 years ago

I integrated your previous changes, and unfortunately it does not fix that issue... Need to do more testing. Maybe I made an error while integrating your changes. I remember having a lot of trouble with that show or hide function. I though I fixed it, but apparently I made it worst... It is not clear why it uses the traitCollection.horizontalSizeClass to decide wether or not to display the Done button (or dismiss or other similar buttons). For reference here is when horizontalSizeClass is compact vs Regular, it appears to me that it is not what we should base the decision to display the button or not. Any thoughts?

ref: https://developer.apple.com/documentation/uikit/uitraitcollection

huguesfcadets commented 3 years ago

The changes are now on branch hugues-63-done-button. I'll continue the work from there.