cadets / cadets-ui

Web-based user interface to CADETS/OPUS
Apache License 2.0
0 stars 0 forks source link

When importing nodes if the correct filter isn't selected the edge will not load #73

Closed gk3758 closed 6 years ago

gk3758 commented 6 years ago

To trigger in NodeSearchsheet Type socket-version next select any node. In the Inspector window Sockets filter isn't selected. Then Individually import each neighbor socket

image

How should this be sorted out? should a warning be given to the user or is this the desired result of not have the filter selected. @trombonehero

trombonehero commented 6 years ago

I think that the filters in the Inspector window should only apply to nodes, and then only to filter which neighbours of the "node under inspection" will be:

  1. shown in the Inspector and/or
  2. imported into a worksheet via "Import Neighbours".

So, the filters should not affect which nodes can be manually inspected, nor should they affect which edges are displayed in a worksheet. I had thought (though I may be mistaken) that the logic for importing nodes into the worksheet had been:

So, if we agree that's the right algorithm (insert discussion here), there may be an implementation issue with the code that was supposed to implement it.

Thoughts?