search

cadeyrn / bookmarks-organizer

With the Bookmarks Organizer it's easy to put order in your bookmarks. The Bookmarks Organizer finds no longer working bookmarks, redirects, duplicates and more!
https://addons.mozilla.org/en-US/firefox/addon/bookmarks-organizer/
Mozilla Public License 2.0
180 stars 31 forks source link

wrong start position for progress bar #231

Open cadeyrn opened 10 months ago

cadeyrn commented 10 months ago

The progress bar has a wrong start position. Users with many bookmarks may see the progress bar only after a little time has passed.

Bildschirmfoto 2023-09-07 um 13 28 21
Illegal-Services commented 9 months ago

image

It seems to me that the progress bar is displaying less then it should, see above screenshot for details... In the screenshot above, I have 6,7K bookmarks but BO's progress bar displays at the begining like if I had 7k+ bookmarks.

Also it's not that of a big issue... Probably the problem is related to how the progress is displayed in it's script between the different scanning threads?

Illegal-Services commented 9 months ago

To fix it idk how your code is currently managed but I suggest making a variable used within all the scripts that updates the progress bar, in the internal extension storage, and so you have the right progression to display all the time.

cadeyrn commented 9 months ago

The progress is calculated after each checked bookmark, and I am not aware of any issues with that. But as described in the issue's description, the start position of the progress bar is wrong. Therefore, the sections in your visualization are probably a bit too short.