search

cadeyrn / bookmarks-organizer

With the Bookmarks Organizer it's easy to put order in your bookmarks. The Bookmarks Organizer finds no longer working bookmarks, redirects, duplicates and more!
https://addons.mozilla.org/en-US/firefox/addon/bookmarks-organizer/
Mozilla Public License 2.0
182 stars 32 forks source link

BO currently skips "Errors" and "Warnings" on some bookmarked links #234

Open BUZZARDGTA opened 1 year ago

BUZZARDGTA commented 1 year ago

Example:

403: http://new2.fjcdn.com/ 404: http://pre06.deviantart.net/

It doesn't detect those as "Error" I'm sure there are SO many other examples for other http codes. I just don't wanna paste here around 400 results x)

I'm curious, how is currently BO displaying links as "Error" ?

BUZZARDGTA commented 1 year ago

So I now figured that the same thing happen for redirections as well, here is a list of links, where bookmarks organizer doesn't "Warnings" their redirected link (some of them can be local to me cuz i'm living in France and they redirect me to their /fr page):

https://www.retroplace.com/ http://www.16personalities.com/ https://www.huiles-guenard.com/ http://thepussycatriot.bigcartel.com/ https://centrespatialguyanais.cnes.fr/ https://www.nature.com/ http://www.dailymail.co.uk/ http://www.cornelius-boutique.com/ http://planetevita.fr/ https://www.seeandsound.be/ http://forums-enseignants-du-primaire.com/ https://www.perigot.fr/ https://www.aprifel.com/ https://www.host-tracker.com/

BUZZARDGTA commented 1 year ago

From watching your source code, and by making tests with python requets, I think the issue for "Warnings", from those links I sent here, is that you are using "HEAD" method, while "GET" is the one working for those sites.

Not sure how you will react to this, as you are probably more acknowledged on the right HTTP method to use and what not. Let me know what you think about it;)

BUZZARDGTA commented 1 year ago

image

Well I've literally only replaced "HEAD" to "GET" from this file: https://github.com/cadeyrn/bookmarks-organizer/blob/master/src/js/core/background.js#L580 and it fixes all of the "Warnings" not showing up. Ikr that "Headers" should be the right thing to use, because it's only prompting well, the header so that makes the request faster, normally. But if it breaks the features, I believe it's bad then ? What do you think ;)

BUZZARDGTA commented 1 year ago

// redirect to identical url. That's weird but there are cases in the real world…

😂 fr I know, I code a similar project and I have that issue as well where people redirect to the same url xD

BUZZARDGTA commented 1 year ago

I'm currently going to rewrite your source code to fix the issue of the 2 dead links above not outputting as "Errors", you will see it's imo very clean code that I personally uses in my python project. I mean the algorythm.